commit ba65fe63adb9071e825df80b1c84985e048ed463
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Mar 8 17:09:58 2025 -0800

    xdm 1.1.17
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 7cc981a7f42ba4db46baafff740e189008202815
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Jan 18 13:38:19 2025 -0800

    if inet_ntop() is available, use it, even if IPv6 support is disabled
    
    Support for using inet_ntop() was originally added to support IPv6,
    and only used if IPv6 support was enabled.  Two decades later, support
    for inet_ntop() is ubiquitous and OS'es have marked inet_ntoa()
    as deprecated, so use the modern interface whenever we can now.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xdm/-/merge_requests/25>

commit 5dc368a3969fbda18a4c9a37d3b47253ea331994
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Jan 18 13:09:12 2025 -0800

    if sockaddr_storage is available, use it, even if IPv6 support is disabled
    
    Support for using sockaddr_storage was originally added to support IPv6,
    and only used if IPv6 support was enabled.  Two decades later, support
    for sockaddr_storage is ubiquitous and works just as well with IPv4,
    so use the modern interface whenever we can now.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xdm/-/merge_requests/25>

commit 5eb1648021bd52322bcb47163117e19b6022ae0a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Jan 12 12:28:43 2025 -0800

    if getaddrinfo() is available, use it, even if IPv6 support is disabled
    
    Support for using getaddrinfo() was originally added to support IPv6,
    and only used if IPv6 support was enabled.  Two decades later, support
    for getaddrinfo() is ubiquitous and OS'es have marked gethostbyname()
    as deprecated, so use the modern interface whenever we can now.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xdm/-/merge_requests/24>

commit 026a10afdbbc3fe9199ede6260fc08897291e3eb
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Jan 12 11:17:53 2025 -0800

    Simplify ifdefs for IPv6 support
    
    Instead of checking for AF_INET6 at every ifdef, just check once for it
    and report that IPv6 support is not available, instead of silently not
    building support for it that configure said we were going to build.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Part-of: <https://gitlab.freedesktop.org/xorg/app/xdm/-/merge_requests/24>

commit 55cb37f064fc32998a035e78d41f3aa852270642
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Apr 4 17:00:32 2024 -0700

    xdm 1.1.16
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 2b451b9915e3a379974a3c2b5fe9d4798f0c136b
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Mon Mar 25 13:06:28 2024 -0700

    Define _CONST_X_STRING when including Xaw & Xt headers
    
    Fixes build when building against libXaw 1.0.16 since
    xorg/lib/libxaw@d0fcbd97 changed the definition of XawListChange
    in <X11/Xaw/List.h> from _Xconst char * to String *, where
    String is defined as const if _CONST_X_STRING is defined.
    
    This also clears up 105 of the 162 -Wdiscarded-qualifiers warnings.
    
    Closes: #16
    Fixes: bccb777 ("Fix -Wincompatible-pointer-types warning from gcc (issue #15)")
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 1a408d7f74618d28db6ec4ec377ab479bd8f75aa
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Mar 23 15:15:52 2024 -0700

    xdm 1.1.15
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 634f47a8aec386b7dedb8f716a65a9b56c0d7de7
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 11:27:55 2024 -0800

    session.c: clear -Wredundant-decls warnings on Solaris
    
    Include standard headers for getpwnam() & crypt() instead of
    local prototype redefinitions.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 2693b540f90e1a79c277bac7ec9fa5e40d05a281
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 11:22:21 2024 -0800

    unifdef __osf__
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit c8af3994d76bc5cc3ee8443c1ee366353daea840
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 11:12:15 2024 -0800

    include <shadow.h> on all platforms with HAVE_GETSPNAM set, not just SVR4
    
    Matches what we already do in greeter/verify.c
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 7e8a581cda4aaac7e1d6af3d0000a0d03816adc3
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 11:02:38 2024 -0800

    Remove support for SVR4 systems other than Solaris/illumos
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 387bcf8bad11196967943a3352b9eb0d0f1f897e
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:47:13 2024 -0800

    unifdef FRAGILE_DEV_MEM
    
    It was only defined in the old Imakefiles, and not in any autoconf config
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit c31f9dcc8055fdf6b5ff2cc59fef89e1cf09a0ab
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:44:17 2024 -0800

    unifdef UNRELIABLE_SIGNALS
    
    UNRELIABLE_SIGNALS was only defined if SYSV was defined
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 48ad0d9b915f858fda2b005d4e7f01ca465a51f9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:42:24 2024 -0800

    unifdef SIGNALS_RESET_WHEN_CAUGHT
    
    SIGNALS_RESET_WHEN_CAUGHT was only defined if SYSV was defined
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 8a9a4e5be8d4906aa7b1365140445db33e6cbbbd
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:41:09 2024 -0800

    unifdef SYSV
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit ae942bf8aba373f3d7db6af868e0f8154fdd23f2
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:35:12 2024 -0800

    unifdef AF_DECnet
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 493673ef4914f56c8ee471b88f16b02e468f9c3b
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:34:22 2024 -0800

    unifdef AF_CHAOS
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 37f80c7716759ed066af68011a35459706e70262
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:26:05 2024 -0800

    unifdef QNX4
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit ee19d5f4352135a9044a238112738dc66ec50b46
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:17:35 2024 -0800

    unifdef __UNIXOS2__
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 2956192801a3e85136d54277409c2ebdea15b3be
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:13:04 2024 -0800

    unifdef pegasus
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 279dba5bed1706ddce0164f78c32a81389b85909
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:08:32 2024 -0800

    unifdef hpux
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 52578f77a14808b7d8925b3ee309d5ceac674b22
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 10:02:29 2024 -0800

    unifdef __convex__
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 1fe9ab1cbf7f0a1684b1f1e53f1a6816916bb3fa
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 09:58:51 2024 -0800

    unifdef PowerMAX_OS
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 9660da78eac0da9ff951ddf0367ad0d09eca885f
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 09:55:27 2024 -0800

    unifdef sony
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 0c49eecefffc16d5ea30709e7901bcdd41136a7c
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Feb 11 09:51:03 2024 -0800

    unifdef ultrix
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 86e227cdfdb9d2454571aa2eb63c81bca139552e
Author: Alisson Bruno <alissonbruno.sa@gmail.com>
Date:   Sun Feb 11 16:56:55 2024 +0000

    Fix --with-systemd-daemon option

commit 9602a9f11dd5ac928a7275ceb1a58d5328b9d49e
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Feb 1 18:16:59 2024 -0800

    greeter: Constify value argument to SetValue()
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 3672840c24e0826b7305d5143c95b2d070c57366
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Feb 1 18:14:56 2024 -0800

    greeter: Handle const qualification differences between Solaris & Linux PAM
    
    Solaris does not specify "const" on the first argument to PAM conversation
    functions, nor the third argument to pam_get_item().  Linux PAM does both.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit bccb77746528134aa2e865ca4f44fd9424738b3f
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Tue Dec 5 17:25:28 2023 -0800

    Fix -Wincompatible-pointer-types warning from gcc (issue #15)
    
    chooser.c:280:26: warning: passing argument 2 of ‘XawListChange’ from
     incompatible pointer type [-Wincompatible-pointer-types]
      280 |     XawListChange (list, newTable, size, 0, TRUE);
          |                          ^~~~~~~~
          |                          |
          |                          char **
    In file included from chooser.c:59:
    /usr/include/X11/Xaw/List.h:170:27: note: expected ‘const char **’ but
     argument is of type ‘char **’
      170 |  _Xconst char           **list,
    
    Closes: #15
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit b2569e49dda3f15b9cbf8df60c86bee9ed01a40a
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Dec 2 10:58:23 2023 -0800

    configure: Use LT_INIT from libtool 2 instead of deprecated AC_PROG_LIBTOOL
    
    AC_PROG_LIBTOOL was replaced by LT_INIT in libtool 2 in 2008,
    so it's time to rely on it.
    
    Clears autoconf warnings:
    
    configure.ac:37: warning: The macro 'AC_LIBTOOL_DLOPEN' is obsolete.
    configure.ac:37: You should run autoupdate.
    m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from...
    configure.ac:37: the top level
    configure.ac:37: warning: AC_LIBTOOL_DLOPEN: Remove this warning and the call to _LT_SET_OPTION when you
    configure.ac:37: put the 'dlopen' option into LT_INIT's first parameter.
    ./lib/autoconf/general.m4:2434: AC_DIAGNOSE is expanded from...
    m4/ltoptions.m4:113: AC_LIBTOOL_DLOPEN is expanded from...
    configure.ac:37: the top level
    configure.ac:38: warning: The macro 'AC_PROG_LIBTOOL' is obsolete.
    configure.ac:38: You should run autoupdate.
    m4/libtool.m4:100: AC_PROG_LIBTOOL is expanded from...
    configure.ac:38: the top level
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit b378b79ce9ae1036fc3d3865186eddf0a56112db
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Fri Oct 13 15:18:27 2023 -0700

    gitlab CI: Update to latest CI templates & Debian stable release
    
    Current template fails to rebuild the CI container with the current
    Debian stable release (a new release since the last update)
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit d2efd22bd2cbee6a04da0bcaec35d03890522dcc
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Feb 25 08:58:08 2023 -0800

    Remove "All rights reserved" from Oracle copyright notices
    
    Oracle no longer includes this term in our copyright & license notices.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 0a94a0a23880e1f6aae6f603d5aab7f7f4df7504
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Jul 28 17:30:21 2022 -0700

    gitlab CI: stop requiring Signed-off-by in commits
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 022b959f5f26e6b70d2ab6524ca39b5934e4c42e
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Dec 3 13:34:29 2022 -0800

    xdm 1.1.14
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 968b9c0b390f15f44ab4f3ee5fce23a9cec60720
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Nov 5 10:37:33 2022 -0700

    Only link with libbsd if needed for arc4random() or setproctitle()
    
    Avoid unnecessary library dependency when using a libc with these
    functions included.
    
    Also only links to the binary that needs them (xdm, not chooser or greeter)
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 8a10c98d29d0ff2028f109b5671dfae2910df051
Author: Guillem Jover <guillem@hadrons.org>
Date:   Thu Oct 6 00:11:18 2022 +0000

    Switch from libbsd to libbsd-overlay
    
    This is the preferred usage form for libbsd, as it makes the code more
    portable and requires no special includes for libbsd, by transparently
    injects the needed standard headers that would be used on a BSD.
    
    Signed-off-by: Guillem Jover <guillem@hadrons.org>

commit 468b76023a2dfb750c4d5e9b184f230c5b6ec670
Author: Callum Farmer <gmbr3@opensuse.org>
Date:   Sun Sep 11 12:57:05 2022 +0100

    genauth: fix build with arc4random in glibc 2.36
    
    HAVE_ARC4RANDOM is defined under glibc 2.36 but this will attempt to include
    <bsd/stdlib.h> from libbsd instead of <stdlib.h> from glibc
    
    Signed-off-by: Callum Farmer <gmbr3@opensuse.org>

commit 0f46b67b45ef40854ad7924e836134bf3f920e09
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Apr 30 11:59:31 2022 -0700

    chooser: avoid free of uninitialized pointer in allocation failure cleanup
    
    Resolves issue found by Oracle Parfait static analyzer:
    
    Error: Uninitialised memory
       Uninitialised memory [uninitialised-mem] (CWE 456):
          Possible access to uninitialised memory referenced by 'new->fullname'
          Memory 'new->fullname' accessed at byte offset '8'
            at line 357 of app/xdm/chooser/chooser.c in function 'AddHostname'.
            Write does not overlap at line 355
              new allocated at line 329
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 3544fa9ec2e17e481785382317ef93ec2ac32ddf
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Apr 10 11:58:38 2022 -0700

    Use memcpy() instead of memmove() when buffers are known not to overlap
    
    Most of these came from a mass bcopy() -> memmove() substitution
    in 1993 with a commit comment of "ANSIfied for R6".
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit f01b28cf76d641881fa1c5bf7f9dd2487b9ced6b
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Apr 10 11:33:38 2022 -0700

    all_query_respond(): handle ConvertAddr failure sooner
    
    Don't try to process returned data values that may not be set
    
    Resolves Oracle Parfait issue:
    
    Error: Uninitialised memory
       Uninitialised memory variable [uninitialised-mem-var] (CWE 457):
          Possible access to uninitialised memory referenced by variable 'length'
            at line 238 of xdm/xdmcp.c in function 'all_query_respond'.
            Path in callee avoiding write at line 237
              length allocated at line 231
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 00e0b3ae11bb1d4681b0206c341f57fc46ea98b1
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Apr 10 11:14:50 2022 -0700

    GetChooserAddr(): verify socket address fit in provided buffer
    
    Should never happen, but makes Oracle Parfait stop warning:
    
    Error: Buffer overrun
       Read Outside Array Bounds in STD C function [read-outside-array-bounds-call-stdc]:
          Read outside array bounds in call to memmove. Buffer ((int8*)&in_addr) of size 256 is read at an offset of len
          Array size is 256 bytes, index <= 1024
            at line 130 of xdm/socket.c in function 'GetChooserAddr'.
            called at line 197 of xdm/choose.c in function 'FormatChooserArgument' with lenp = &addr_len.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit c7daccd105a74fe97adb2c8e2842e3b19d5dd34c
Author: Matt Turner <mattst88@gmail.com>
Date:   Sun Apr 10 12:40:13 2022 -0700

    configure.ac: Add option to disable Xinerama
    
    Bug: https://bugs.gentoo.org/384371
    Signed-off-by: Matt Turner <mattst88@gmail.com>

commit df5bb7f4e4039192571de75179658ee9c2ee58eb
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Apr 3 14:42:16 2022 -0700

    xdm 1.1.13
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit d0fa51471049d427b95346dd7ffc17ff9c17b1d9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Dec 4 11:46:06 2021 -0800

    Build xz tarballs instead of bzip2
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 943f2aa19005c53ee5c7c0782af382948e689af1
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Dec 4 11:46:02 2021 -0800

    gitlab CI: add a basic build test
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit c84d3f77abdb5502140ba36137c25a6dd07df756
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Nov 1 10:20:02 2020 -0800

    doneAddrs: reset addrs to NULL after freeing list
    
    Resolves warning from Oracle Parfait static analyzer:
    
    Warning: Dangling pointer
       Dangling pointer [dangling-pointer]:
          Invalid pointer is accessible to caller via global addrs
            at line 664 of xdm/auth.c in function 'doneAddrs'.
            Invalid pointer accessible via global addrs at line 646
              a accessed from addrs at line 658 in function 'doneAddrs'
              a freed with free at line 662
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 9505d391c72c90635453cc160b6f64e02da6a318
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Nov 1 10:05:11 2020 -0800

    Greeter: add parens to DRAW_STRING & TEXT_WIDTH macros for safety
    
    Oracle Parfait static analyser points out it wasn't clear if cast or
    arithmetic operation in arguments at lines 410, 416, 431, & 433 was
    intended to be done first, so we'll make it explicit.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 529ff7c9591e58c6003d7b330a80adf63fa5b736
Author: Matt Turner <mattst88@gmail.com>
Date:   Wed Oct 28 21:15:14 2020 -0400

    configure.ac: Link with libsystemd, not libsystemd-daemon
    
    libsystemd-daemon was merged into libsystemd in 2014, for systemd-209.
    
    Fixes: https://gitlab.freedesktop.org/xorg/app/xdm/-/issues/9
    Signed-off-by: Matt Turner <mattst88@gmail.com>

commit 945a3a05e53ddd32578d5146ec4943fe9297aba4
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Tue Jul 21 19:04:11 2020 -0700

    Fix spelling/wording issues
    
    Found by using:
      codespell --builtin clear,rare,usage,informal,code,names
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit a03a628e2adeac10aa0fc494a5f04f25e3b31d7e
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat Mar 2 14:02:19 2019 -0800

    xdm 1.1.12
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 5f941a815b7bad49a766987660094b01046c8e7d
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Mon Feb 25 14:22:27 2019 -0800

    Use sed instead of the C pre-processor to generate config files
    
    Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=93359
    while avoiding https://bugs.freedesktop.org/show_bug.cgi?id=107368
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit dd7402c2f1e828cc3b0fae036b62f74b8014814b
Author: David Carlier <devnexen@gmail.com>
Date:   Wed May 4 17:46:15 2016 +0100

    fix length format in StartClient() debug message
    
    changing the printf-like format as strlen returns an unsigned type
    
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 42ae3d66283a9efa0c510d5d438f821549656fe6
Author: David Carlier <devnexen@gmail.com>
Date:   Wed May 4 17:46:15 2016 +0100

    fix memory leak in StorePid()
    
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 7a56946260616f7f5ff43ecbaac1f2ada9b0afcd
Author: Chí-Thanh Christopher Nguyễn <chithanh@gentoo.org>
Date:   Mon Jan 6 15:52:47 2014 +0000

    xdm uses setproctitle without proper includes for Linux libbsd
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 786b2c7ed39fb0cdd4c34e51f5c58f980087dcc1
Author: Chí-Thanh Christopher Nguyễn <chithanh@gentoo.org>
Date:   Mon Jan 6 15:52:00 2014 +0000

    xdm uses arc4random without proper includes for Linux libbsd
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 16d74befa4430eb024d81ee4070520afff697d60
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Wed Nov 21 17:01:20 2018 -0800

    Update configure.ac bug URL for gitlab migration
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit a7623a6555689cb3d1acfc66c0562985b106a85b
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Fri Nov 16 21:30:06 2018 -0800

    Update README for gitlab migration
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 768a8c524642955527066ba90be6ffd511e30ed5
Author: Björn Esser <besser82@fedoraproject.org>
Date:   Thu Aug 16 15:42:34 2018 -0400

    glibc: Include <crypt.h> if needed, fix build with 2.28
    
    Signed-off-by: Adam Jackson <ajax@redhat.com>

commit b6853380678b793bad81ac09b2f872f8225ccec6
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat May 5 12:28:27 2018 -0700

    Add missing brackets to multi-statement if in SaveServerAuthorizations
    
    Introduced by commit 5222d28e8d8e5b4cc
    
    Reported by gcc 7.3:
    
    auth.c: In function ‘SaveServerAuthorizations’:
    auth.c:447:6: warning: this ‘if’ clause does not guard... [-Wmisleading-indentation]
          if (auths[i]->data_length > 0)
          ^~
    auth.c:452:3: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
       (void) fflush (auth_file);
       ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>

commit 50bd014ad8ed0b0af1e9e8130779acd0473a6899
Author: Matthieu Herrb <matthieu@herrb.eu>
Date:   Sun Oct 1 09:43:53 2017 +0200

    chown before chmod
    
    This prevents a malicious user logging out from calling
    chmod while still owning /dev/console and thus by-passing
    the '622' mode that is set here.
    
    Issue reported by Tim Chase. Thanks.
    
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 4743378ccf1defe5984ad71797283b98029aa920
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Mon Jan 16 16:21:37 2017 -0800

    Install xdm man pages under admin section (8), not user programs (1)
    
    As best I can tell, it was historically under section 1 mainly because
    the old X Consortium Imake configs only supported installing program
    man pages there, and didn't have an option for using other sections.
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>

commit 53a781392bdd785db8a12572a7323de35a16d896
Author: Mihail Konev <k.mvc@ya.ru>
Date:   Thu Jan 26 14:00:21 2017 +1000

    autogen: add default patch prefix
    
    Signed-off-by: Mihail Konev <k.mvc@ya.ru>

commit 6004d4b43e76522528cb93f56b38f4f5130d4e1f
Author: Emil Velikov <emil.l.velikov@gmail.com>
Date:   Mon Mar 9 12:00:52 2015 +0000

    autogen.sh: use quoted string variables
    
    Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
    fall-outs, when they contain space.
    
    Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
    Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

commit 62e239d1ea3294239830f39ac8e4d21b6b17ec8d
Author: Peter Hutterer <peter.hutterer@who-t.net>
Date:   Tue Jan 24 10:32:07 2017 +1000

    autogen.sh: use exec instead of waiting for configure to finish
    
    Syncs the invocation of configure with the one from the server.
    
    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
    Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

commit 02c5858734585795f53b90a245afafb3c606c5ce
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Jan 28 09:02:06 2016 -0800

    Remove non-existent cpp resource from man page
    
    From what I can see in the ancient X Consortium archives, the cpp
    resource was added in X11R4 and documented but never actually used,
    and removed in X11R5 without remembering to remove it from the man page.
    
    Reported-by: John Smith <wempwer@gmail.com>
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
    Reviewed-by: Matthieu Herrb <matthieu@herrb.eu>
    Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

commit 994d32ad92e12aa381f222db68db9997a602197e
Author: Matthieu Herrb <matthieu@herrb.eu>
Date:   Tue Jan 5 21:31:12 2016 +0100

    Missed on arc4random() conversion.
    
    Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 5defb9365b7bfb758024ed203b30ee245285b77f
Author: Matthieu Herrb <matthieu@herrb.eu>
Date:   Mon Oct 26 17:09:53 2015 +0100

    Unifdef X_NO_SYS_UN
    
    Nothing has set that since the modularization
    
    Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 720378013765a5bad7bddbb775aa6845c6d9c4af
Author: Matthieu Herrb <matthieu@herrb.eu>
Date:   Mon Oct 26 16:59:09 2015 +0100

    Remove AIXV3, SCO, Unixware, OS/2 support
    
    Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 82298bc7aa1b1715adce9de1cf61c6335bc659d8
Author: Matthieu Herrb <matthieu@herrb.eu>
Date:   Tue Dec 1 19:15:50 2015 +0100

    Remove #if 0'd code
    
    Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
    Reviewed-by: Adam Jackson <ajax@redhat.com>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit c0c3ad0cc5a6e5cf528245fb7f4e47b91163333c
Author: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date:   Sun Oct 18 22:35:00 2015 -0700

    Fixup various format warnings in PrintProtoDisplay
    
    protodpy.c:52:35: warning: format specifies type 'unsigned int' but the argument has type 'struct protoDisplay *' [-Wformat]
        Debug ("ProtoDisplay 0x%x\n", pdpy);
                               ~~     ^~~~
    protodpy.c:54:20: warning: incompatible pointer types passing 'XdmcpNetaddr' (aka 'char *') to parameter of type 'struct sockaddr *'
          [-Wincompatible-pointer-types]
        PrintSockAddr (pdpy->address, pdpy->addrlen);
                       ^~~~~~~~~~~~~
    ../include/dm_socket.h:46:45: note: passing argument to parameter 'a' here
    extern void PrintSockAddr (struct sockaddr *a, int len);
                                                ^
    protodpy.c:55:41: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
        Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date);
                       ~~                   ^~~~~~~~~~
                       %lu
    protodpy.c:55:53: warning: format specifies type 'int' but the argument has type 'unsigned long' [-Wformat]
        Debug ("\tdate %d (%d from now)\n", pdpy->date, time(0) - pdpy->date);
                           ~~                           ^~~~~~~~~~~~~~~~~~~~
                           %lu
    protodpy.c:57:32: warning: format specifies type 'int' but the argument has type 'CARD32' (aka 'unsigned long') [-Wformat]
        Debug ("\tsessionID %d\n", pdpy->sessionID);
                            ~~     ^~~~~~~~~~~~~~~
                            %lu
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

commit d5aa455a2575fca74219bb567ae4cb8c63a8401d
Author: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date:   Sun Oct 18 22:21:05 2015 -0700

    Silence -Wmissing-noreturn warnings
    
    choose.c:463:1: warning: function 'RunChooser' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    chooser.c:1062:1: warning: function 'DoCancel' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    reset.c:81:1: warning: function 'abortReset' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    server.c:154:1: warning: function 'serverPauseAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    server.c:161:1: warning: function 'serverPauseUsr1' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    server.c:236:1: warning: function 'abortOpen' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    server.c:329:1: warning: function 'PingLost' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    server.c:348:1: warning: function 'PingLostSig' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:231:1: warning: function 'catchTerm' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:293:1: warning: function 'SessionPingFailed' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:240:1: warning: function 'catchAlrm' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:249:1: warning: function 'waitAbort' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:330:1: warning: function 'ManageSession' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:471:1: warning: function 'syncTimeout' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    session.c:519:1: warning: function 'SessionExit' could be declared with attribute 'noreturn' [-Wmissing-noreturn]
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

commit 6cc5153d77f9f48b8dd16e17e48eac4d6ef13929
Author: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date:   Sun Oct 18 22:13:31 2015 -0700

    Add missing prototype for PrintSockAddr
    
    protodpy.c:53:5: error: implicit declaration of function 'PrintSockAddr' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
        PrintSockAddr (pdpy->address, pdpy->addrlen);
        ^
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

commit 68de911889c66133cc6e2f5c64b18a02e84de500
Author: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date:   Sun Oct 18 22:12:14 2015 -0700

    Add missing return type (void) for PrintProtoDisplay
    
    protodpy.c:49:1: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
    PrintProtoDisplay (struct protoDisplay *pdpy)
    ^
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

commit 0d8bb02d5ab7af1dc505987c9468c11caf3b889d
Author: Jeremy Huddleston Sequoia <jeremyhu@apple.com>
Date:   Sun Oct 18 22:10:41 2015 -0700

    xdm: Add missing include of <arpa/inet.h> for inet_ntop
    
    netaddr.c:226:2: error: implicit declaration of function 'inet_ntop' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
            inet_ntop(a->sa_family, &((struct sockaddr_in6 *) a)->sin6_addr,
            ^
    
    Signed-off-by: Jeremy Huddleston Sequoia <jeremyhu@apple.com>

commit 29ec7d1a3bad0222c58a6be2a3a5d81706ce26e5
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sun Sep 27 18:47:14 2015 -0700

    Get rid of an extraneous ; at the end of a C source line
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit f4ddb33f2168acfee0034379c2f69c82e0aa768a
Author: Egbert Eich <eich@suse.de>
Date:   Fri May 22 10:36:03 2015 +0200

    dm: Don't crash if argc == 0
    
    It is not guaranteed that argc > 0. So make sure we don't crash
    if no valid command line arguments are given.
    
    Signed-off-by: Egbert Eich <eich@suse.de>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit d0e32620bfb3bc8803bffcec3f0f3b1db6440d51
Author: Matthieu Herrb <matthieu@herrb.eu>
Date:   Sat Mar 14 20:05:25 2015 +0100

    Allow the greeter to set the input fields bg color
    
    A new 'inpColor' resource is added for that.
    
    Signed-off-by: Matthieu Herrb <matthieu@herrb.eu>
    Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 6abf2827dd4f0dc1a4972c431131de94fb978199
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Feb 26 23:05:24 2015 -0800

    Mark LogPanic as noreturn per gcc's suggestion
    
    error.c: In function ‘LogPanic’:
    error.c:93:1: warning: function might be candidate for attribute ‘noreturn’
     [-Wsuggest-attribute=noreturn]
     LogPanic (const char * fmt, ...)
     ^
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit d26ca678071aeaf41d91985ebf8a194231667b24
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Thu Feb 26 22:32:21 2015 -0800

    Only free input or output to realloc, not both
    
    In error cleanup path, check to see if realloc returned NULL,
    if so, free the still valid input pointer; otherwise the input is
    no longer valid, so ignore it and free the realloc output pointer.
    Avoids potential double free if you run out of memory at the exact
    right spot.
    
    Introduced-by: commit d39dbde390f0f609c03dbd79f0bcc6a3486ca8a3
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit bd28d86465fc6ba48f6f35ddeb8df9275960b1de
Author: Jon TURNEY <jon.turney@dronecode.org.uk>
Date:   Mon Feb 23 11:36:41 2015 +0000

    Link libXdmGreet with -no-undefined libtool flag
    
    "Use -no-undefined to assure libtool that the library has no unresolved symbols
    at link time, so that libtool will build a shared library on platforms that
    require that all symbols are resolved when the library is linked."
    
    With a recent libtool (since 2.4.5 or so), "can't build <target> shared library
    unless -no-undefined is specified" is an error, rather than a warning, if
    ./configure'd --enable-shared.
    
    http://tinderbox.x.org/builds/2015-02-22-0009/logs/app-xdm/#build
    
    Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>

commit cdc7b575452a621fb467004d607288af6dd4c802
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Tue Nov 4 21:44:05 2014 -0800

    Only pass -u & -w args to sessreg if --with-{u,w}tmp-file=path specified
    
    If not specified, let sessreg use its builtin defaults instead of
    replicating the logic here (and possibly getting it wrong), especially
    since in sessreg-1.0.8 and earlier, using the -u & -w flags forces
    the use of the utmp/wtmp code and not the newer utmpx/wtmpx code.
    
    If --without-{u,w}tmp-file or --with-{u,w}tmp-file=none is specified,
    pass "none" as arguments to sessreg to disable writing to that file.
    
    v2: better handling of --with & --without arguments when not passing path,
    add documentation of the 3 choices to README
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit a69c64584f614eeaeac92a068715ced5777b0ec9
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Fri Aug 1 22:58:54 2014 -0700

    Protect against unlikely NULL pointer dereference in FormatChooserArgument
    
    NetaddrPort should only return NULL if it wasn't compiled with
    support for the address family in use, but checking to be sure
    makes static analyzer complain less.
    
    Error: Null pointer dereference (CWE 476)
       Read from null pointer port
            at line 219 of xdm/choose.c in function 'FormatChooserArgument'.
              Function NetaddrPort may return constant 'NULL' at line 77,
               called at line 216.
              Null pointer introduced at line 77 of xdm/netaddr.c in function
               'NetaddrPort'.
            at line 220 of xdm/choose.c in function 'FormatChooserArgument'.
              Function NetaddrPort may return constant 'NULL' at line 77,
               called at line 216.
              Null pointer introduced at line 77 of xdm/netaddr.c in function
               'NetaddrPort'.
    
    [ This bug was found by the Parfait 1.4.0 bug checking tool.
      http://labs.oracle.com/pls/apex/f?p=labs:49:::::P49_PROJECT_ID:13 ]
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit 95e6f0ed0730c296b6c52b024c67d86507de1348
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat May 31 21:39:32 2014 -0700

    autogen.sh: Honor NOCONFIGURE=1
    
    See http://people.gnome.org/~walters/docs/build-api.txt
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit c1375955b733ee8281520e283c7cfb3d93f6d2cf
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Sat May 31 21:38:41 2014 -0700

    configure: Drop AM_MAINTAINER_MODE
    
    Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

commit f5737904cb77fa546523615bf1582979b2744607
Author: Alan Coopersmith <alan.coopersmith@oracle.com>
Date:   Fri Oct 18 22:54:29 2013 -0700

    Ensure fgets read at least one byte before modifying string
[--snip--]
